refactor: consolidate datafusion session setup #3860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
force-pushed
the
refactor/df-session
branch
from
b0615bd to
95512a3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3860 +/- ##
==========================================
- Coverage 73.79% 73.76% -0.03%
==========================================
Files 151 152 +1
Lines 39149 39122 -27
Branches 39149 39122 -27
==========================================
- Hits 28891 28860 -31
- Misses 8987 8989 +2
- Partials 1271 1273 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Oct 17, 2025
roeap
force-pushed
the
refactor/df-session
branch
5 times, most recently
from
9012939 to
cbe7f16
Compare
roeap
force-pushed
the
refactor/df-session
branch
2 times, most recently
from
454d655 to
dad3f48
Compare
Signed-off-by: Robert Pack <[email protected]>
roeap
force-pushed
the
refactor/df-session
branch
from
dad3f48 to
17ba5f7
Compare
rtyler
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are still creating sessions in several places in the codebase. With this PR, we create a single code path (or at least module) to create datafusion sessions. We also further generalise some APIs to use the
Sessiontrait.The main code paths where we still use
SessionStatewhenever we need to use theDataFrameabstraction. These might disappear once we start planning more based on data.Closing the related issue for now, since further improvements are part of larger refactorings.
Related Issue(s)